Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcc to the prequisites list #223

Open
samuel-rubin opened this issue Feb 1, 2019 · 3 comments
Open

Add gcc to the prequisites list #223

samuel-rubin opened this issue Feb 1, 2019 · 3 comments
Labels

Comments

@samuel-rubin
Copy link

I was looking at my logs for a sanity.system test and I noticed that it used GCC. I then went to the prerequisites list and I noticed that GCC was not listed.
Can you please update the prerequisite list to indicate that GCC is required and which version is needed if applicable?
Related to eclipse-openj9/openj9#4208

@karianna karianna added the bug label Feb 1, 2019
@Mesbah-Alam
Copy link
Contributor

GCC is required to build the 'native' system tests, yes. So, I do agree that we should add it in the prerequisite list. However, I am not sure if there is any specific version (or later than that) must be present to compile the native system tests. They have traditionally had no problems with whatever GCC the test machine comes with.

@lumpfish - any comment?

@Mesbah-Alam
Copy link
Contributor

Equivalent issue in openj9-systemtest: adoptium/openj9-systemtest#82

@lumpfish
Copy link
Contributor

Microsoft Visual Studio is required for Windows, gcc for all other platforms.
The build never added a prereq target to install gcc because all the systems it was originally developed on (and since then, other than via this issue) had a gcc installed.
So there is no defined minimum gcc level required for the native test cases to build. They will have been built in the past with versions which predate anything installed on today's machines.
I think I'd leave the openjdk-systemtest build as is - i.e. assume a gcc is present. A build / test machine will typically have a gcc installed on it anyway (to build the jdk) - that level (required for building the jdk) will be adequate for building the native system test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants