Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto approve and merge pull requests by Dependabot #2343

Open
sophia-guo opened this issue Mar 8, 2021 · 5 comments
Open

Auto approve and merge pull requests by Dependabot #2343

sophia-guo opened this issue Mar 8, 2021 · 5 comments

Comments

@sophia-guo
Copy link
Contributor

Details see adoptium/run-aqa#72. The requirement mainly fits to projects with typescript.

@sophia-guo
Copy link
Contributor Author

Same requirement for openjdk-test-tools repo. adoptium/aqa-test-tools#372

@llxia
Copy link
Contributor

llxia commented Mar 9, 2021

We need to be very careful with the auto-merge. Some 3rd party lib upgrades will break the code. And I think it may not be a good idea to auto-merge any PR from a bot.

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Mar 9, 2021

Yes, we need to be careful about the auto merge. However it depends on how we use it. Dependabot will resolve any conflicts with its created PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Also note: Dependabot will wait until all your status checks pass before merging. This is a function of Dependabot itself, https://github.com/marketplace/actions/dependabot-auto-merge. We could setup workflows for PRs created by Dependabot ( or could just setup the normal workflow it depends) so auto merge would not work if any status checks fail. Hence no build will be broken.

@llxia
Copy link
Contributor

llxia commented Mar 10, 2021

Talked with Sophia, we may need to evaluate this case by case. For https://github.com/AdoptOpenJDK/openjdk-test-tools, I think we need to create PR builds first. Issue created at adoptium/aqa-test-tools#374

@sophia-guo
Copy link
Contributor Author

May also extend to PR of github-actions #2319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants