Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when running build pipeline which do not have sign_temurin_gpg #981

Open
mahdipub opened this issue Mar 21, 2024 · 3 comments
Open
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts testing

Comments

@mahdipub
Copy link
Contributor

  • no jenkins pipeline job
  • all platforms

I have a question regarding a piece of build code.
/pipelines/build/common/openjdk_build_pipeline.groovy

if (!env.JOB_NAME.contains('pr-tester')) {
    try {
        gpgSign()
    } catch (Exception e) {
        context.println(e.message)
    }
}

This condition always is true in our environment for all platforms and we will end up failure as we do not have any gpgSign() -> build-scripts/release/sign_temurin_gpg to run.

Can we have a more accurate condition here to avoid it run for non-adoptium users?

@mahdipub mahdipub added the buildbreak High priority issues that cause build breaks in jenkins or build scripts label Mar 21, 2024
@AdamBrousseau
Copy link
Contributor

I think the ask is if we can submit a change to add a condition to that if line. Either !openj9 or JENKINS_URL.contains('adopt') like we did here
https://github.com/ibmruntimes/ci-jenkins-pipelines/blob/3d3cc13c466878349f5d6702381c6def555d4250/pipelines/build/common/create_job_from_template.groovy#L71

@AdamBrousseau
Copy link
Contributor

I see in the Adopt OpenJ9 builds the sign_temurin_gpg job is run
ex
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-ppc64le-openj9/1339/consoleFull

14:42:36  RUNNING sign_temurin_gpg for linux/ppc64le ...
[Pipeline] build (Building build-scripts » release » sign_temurin_gpg)
14:42:36  Scheduling project: [build-scripts » release » sign_temurin_gpg](https://ci.adoptium.net/job/build-scripts/job/release/job/sign_temurin_gpg/)
14:42:45  Starting building: [build-scripts » release » sign_temurin_gpg #27185](https://ci.adoptium.net/job/build-scripts/job/release/job/sign_temurin_gpg/27185/)
14:44:47  Build [build-scripts » release » sign_temurin_gpg #27185](https://ci.adoptium.net/job/build-scripts/job/release/job/sign_temurin_gpg/27185/) completed: SUCCESS
[Pipeline] node
14:44:47  Running on [jenkins-worker](https://ci.adoptium.net/computer/jenkins%2Dworker/) in /home/jenkins/workspace/build-scripts/jobs/jdk11u/jdk11u-linux-ppc64le-openj9
[Pipeline] {
[Pipeline] sh
14:44:49  + rm -rf workspace/target/*
[Pipeline] copyArtifacts
14:44:52  Copied 4 artifacts from "[build-scripts » release » sign_temurin_gpg](https://ci.adoptium.net/job/build-scripts/job/release/job/sign_temurin_gpg/)" build number [27185](https://ci.adoptium.net/job/build-scripts/job/release/job/sign_temurin_gpg/27185/)
[Pipeline] timeout
14:44:52  Timeout set to expire in 6 hr 0 min
[Pipeline] {
[Pipeline] archiveArtifacts
14:44:52  Archiving artifacts

So I'm guessing the solution here will be to add the latter option to that if so that Adopt continues to sign their OpenJ9 builds. @mahdipub can you open a PR with that please?
JENKINS_URL.contains('adopt')

@mahdipub
Copy link
Contributor Author

This PR regarding this issue.

#983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts testing
Projects
Status: Todo
Development

No branches or pull requests

2 participants