Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jenkins error logging in installer jenkinsfile & fix typo #1103 #1104

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

steelhead31
Copy link
Contributor

The handling of none linux packages, has shown a typo in printlin rather than println.

Also as the upstream job that triggers the build of the new linux packages cannot be selective, I need to handle the additional parameters to reduce entries in the jenkins warning logs. These parameters will not be used, just added to the pipeline to remove the warning about unhandled parameters.

Part of #1005

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@steelhead31
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@karianna
Copy link
Contributor

/approve

1 similar comment
@gdams
Copy link
Member

gdams commented Jan 23, 2025

/approve

@github-actions github-actions bot dismissed their stale review January 23, 2025 08:26

Thank you @karianna and @gdams for your approvals, this pull request is now approved to merge during release.

@karianna karianna merged commit ec2a895 into adoptium:master Jan 23, 2025
6 checks passed
@steelhead31 steelhead31 self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants