Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdLineTester_SCCommandLineOptionTests_1 fail (jdk8,11,15/j9) #39

Closed
smlambert opened this issue Nov 5, 2020 · 6 comments · Fixed by #51
Closed

cmdLineTester_SCCommandLineOptionTests_1 fail (jdk8,11,15/j9) #39

smlambert opened this issue Nov 5, 2020 · 6 comments · Fixed by #51
Labels
bug Something isn't working
Milestone

Comments

@smlambert
Copy link
Contributor

https://github.com/AdoptOpenJDK/run-aqa/runs/1354982566?check_suite_focus=true#step:4:50735
Testing: Run !printallcallsites
Test start time: 2020/11/04 21:36:14 Coordinated Universal Time
Running command: /opt/hostedtoolcache/jdk-8-openj9/1.0.0/x64/bin/jdmpview -core j9core.dmp
Time spent starting: 2 milliseconds
Time spent executing: 689 milliseconds
Test result: FAILED
Output from test:
[OUT] DTFJView version 4.29.5, using DTFJ version 1.12.29003
[OUT] Loading image from DTFJ...
[OUT]
[OUT] Could not load dump file and/or could not load XML file: null
[OUT] For a list of commands, type "help"; for how to use "help", type "help help"
[OUT] > DDR is not enabled for this core file, '!' commands are disabled
[OUT] >

https://github.com/AdoptOpenJDK/run-aqa/runs/1354982566?check_suite_focus=true#step:4:53130
[OUT] nameOption2: Expected to find the cache name
[OUT] TEST PASSED
[ERR] JVMSHRC806I Compressed references persistent shared cache "runner" has been destroyed. Use option -Xnocompressedrefs if you want to destroy a non-compressed references cache.

@karianna karianna added the bug Something isn't working label Nov 5, 2020
@sophia-guo
Copy link
Contributor

Looks like cmdLineTester_callsitedbgddrext_openj9 passed in recent running. https://github.com/AdoptOpenJDK/run-aqa/runs/1476255594?check_suite_focus=true#step:4:33468. Not sure if it's intermittent or fixed.

@smlambert smlambert changed the title cmdLineTester_callsitedbgddrext_openj9/cmdLineTester_SCCommandLineOptionTests_1 fail (jdk8/j9) cmdLineTester_SCCommandLineOptionTests_1 fail (jdk8/j9) Dec 1, 2020
@smlambert
Copy link
Contributor Author

Updating this issue to remove cmdLineTester_callsitedbgddrext_openj9 from the heading. That test was failing consistently a few weeks ago, but has not failed for a while. I do not see an obvious PR/fix that would change behaviour, but we can raise it as a separate issue if its turned into something intermittent.

@sophia-guo
Copy link
Contributor

Update cmdLineTester_SCCommandLineOptionTests_1 failures on linux with jdk8/11/15 ( Original one is the failure of cmdLineTester_callsitedbgddrext_openj9):

Testing: nameOption2
Test start time: 2020/12/02 20:42:49 Coordinated Universal Time
Running command: sh nameOption2.sh /opt/hostedtoolcache/jdk-8-openj9/1.0.0/x64/bin
Time spent starting: 1 milliseconds
Time spent executing: 272 milliseconds
Test result: FAILED
[OUT] Hello, world!
[OUT] TEST PASSED
[OUT] nameOption2: TEST FAILED
[OUT] nameOption2: Expected to find the cache name
[OUT] TEST PASSED
[ERR] JVMSHRC806I Compressed references persistent shared cache "runner" has been destroyed. Use option -Xnocompressedrefs if you want to destroy a non-compressed references cache.

Success condition was found: [Output match: TEST PASSED]
Failure condition was found: [Output match: TEST FAILED]
Failure condition was not found: [Output match: Error:]
Failure condition was not found: [Output match: Unhandled Exception]
Failure condition was not found: [Output match: Exception:]

...
Testing: nameOption4
Test start time: 2020/12/02 20:42:50 Coordinated Universal Time
Running command: sh nameOption4.sh /opt/hostedtoolcache/jdk-8-openj9/1.0.0/x64/bin
Time spent starting: 8 milliseconds
Time spent executing: 276 milliseconds
Test result: FAILED
[OUT] Hello, world!
[OUT] TEST PASSED
[OUT] nameOption4: TEST FAILED
[OUT] nameOption4: Expected to find the cache name
[OUT] TEST PASSED
[ERR] JVMSHRC806I Compressed references persistent shared cache "_runner_docker" has been destroyed. Use option -Xnocompressedrefs if you want to destroy a non-compressed references cache.

Success condition was found: [Output match: TEST PASSED]
Failure condition was found: [Output match: TEST FAILED]
Failure condition was not found: [Output match: Error:]
Failure condition was not found: [Output match: Unhandled Exception]
Failure condition was not found: [Output match: Exception:]

@sophia-guo
Copy link
Contributor

cmdLineTester_callsitedbgddrext_openj9 reopened in #50

@sophia-guo
Copy link
Contributor

sophia-guo commented Dec 10, 2020

Test nameOption2 and nameOption4 get the username from the environment variable LOGNAME
export TESTUSER=$LOGNAME

to match the shared Cache generated by NAME=_%u.

In github runner ubuntu environment _%u is runner and $LOGNAME turns out be empty ( github runner macos $LOGNAME is runner, so test passes with macos).

This actually should also affect test nameOption, which set DEFAULT_CACHE_NAME="sharedcc_$TESTUSER" . However as TESTUSER is empty so grep "$DEFAULT_CACHE_NAME" $TESTSCRIPT.out will return 0. Kind of luck, test is actually fragile.

Next step would need to figure out why $LOGNAME is empty on ubuntu runner, and be runner on macos runner. Is this expected?

Screen Shot 2020-12-10 at 5 27 47 PM

Screen Shot 2020-12-10 at 5 27 26 PM

@sophia-guo
Copy link
Contributor

LOGNAME is not in the Ubuntu GitHub Actions Environment Variables List. Instead RUNNER_USER is the environment for the user runner. There’s always a chance that the list will get outdated as soon as a new container is configured. We will put a warning if it happens and update our fixes.

@sophia-guo sophia-guo changed the title cmdLineTester_SCCommandLineOptionTests_1 fail (jdk8/j9) cmdLineTester_SCCommandLineOptionTests_1 fail (jdk8,11,15/j9) Dec 11, 2020
@karianna karianna added this to the December 2020 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants