Abstract out sed -i parameter for macos in repro_common.sh

[sxa]

At the moment we have blocks like this in repro_common.sh:

if [[ $(uname) =~ Darwin* ]]; then
    echo "Removing Temurin specific lines from release file in $DIR"
    sed -i "" '/^BUILD_SOURCE=.*$/d' "${DIR}/release"
    sed -i "" '/^BUILD_SOURCE_REPO=.*$/d' "${DIR}/release"
[...]
    echo "Removing SOURCE= from ${DIR}/release file, as Temurin builds from Adoptium mirror repo _adopt tag"
    sed -i "" '/^SOURCE=.*$/d' "${DIR}/release"
else
    echo "Removing Temurin specific lines from release file in $DIR"
    sed -i '/^BUILD_SOURCE=.*$/d' "${DIR}/release"
    sed -i '/^BUILD_SOURCE_REPO=.*$/d' "${DIR}/release"
[...]
fi

A nicer solution would be to use multiple -e parameters to sed (I'm assuming that will be find on macos too) and use a variable to switch between the two parameter formats in order to avoid code duplication e.g:

if [ $(uname) = "Darwin" ]; then
   SED_INLINE='-i ""'
else
  SED_INLINE="-i"
fi
    echo "Removing Temurin specific lines from release file in $DIR"
    sed $SED_INLINE '/^BUILD_SOURCE=.*$/d' "${DIR}/release"
    sed $SED_INLINE '/^BUILD_SOURCE_REPO=.*$/d' "${DIR}/release"
[...]