Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt attribute #234

Open
AnthelmeLC opened this issue Mar 9, 2023 · 6 comments
Open

alt attribute #234

AnthelmeLC opened this issue Mar 9, 2023 · 6 comments

Comments

@AnthelmeLC
Copy link

Hi !

Is it possible to add alt attribute to your component, and set it to the img element built to improve the accessibility please ?

@Norserium
Copy link
Collaborator

@AnthelmeLC, do you want to add it dynamically like src?

@AnthelmeLC
Copy link
Author

Yes please :)

@Norserium
Copy link
Collaborator

@AnthelmeLC, and what it would give to an user? The cropper still won't be accessible.

@AnthelmeLC
Copy link
Author

it add a description for browser reader. And yes the component will not be 100% accessible, but i'm not an expert, and just try to contribute like i can. 1% accessible is better than 0% and it's a good start to improve your accessibility .

@Norserium
Copy link
Collaborator

@AnthelmeLC, there is truth in your words. But this approach is opposite to system approach, that I prefer.

Did you see any cropper that support accessibility? It would be helpful to me to understand the whole approach that should be implemented.

@AnthelmeLC
Copy link
Author

Sorry for the long time i didn't answered.

I only use your cropper, so i can't help more sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants