Replies: 8 comments 23 replies
-
Your help on this would be greatly appreciated. I got as far as building the executable for the node server and setting up a tray app. The tray app I put on github for sharing my effort but doesn't need to be continued, a new project can be setup if there is a better solution. It is here https://github.com/advplyr/audiobookshelf-win There are technically 2 dependencies, ffmpeg and tone, however we can disregard tone since I plan on removing this. Tone is used for embedding metadata but we can use ffmpeg for that. Ffmpeg has limitations for writing metadata but not enough to justify a separate dependency. Building the installer is where things got difficult for me. My original plan was to have the installer install ffmpeg and to build the tray app so that it can be updated. This would make it so that you can update the tray application through the GUI as well as update the server version. I setup the tray app to check for updates of the server in a github repository. For a while I was building the exe and putting it in the release assets https://github.com/advplyr/audiobookshelf/releases/tag/v2.1.4. I stopped because it was confusing a lot of users who thought this was a production ready windows release. Those exe's do work as long as you have ffmpeg installed. The tray app is starting those exe's in the background and passing in arguments for port number, file paths, etc. https://github.com/advplyr/audiobookshelf-win/blob/master/WinApp/audiobookshelf/TrayOnly.cs#L267 Just to reiterate, we don't need to use that tray app I built if you have a better approach and it may be cleaner to start from scratch. Let me know what you think |
Beta Was this translation helpful? Give feedback.
-
I'll take a look at what you started and I'll let you know. |
Beta Was this translation helpful? Give feedback.
-
@advplyr , For ffmpeg installation, which build should we install, the essentials or full? |
Beta Was this translation helpful? Give feedback.
-
Another couple of questions:
Yet another possible approach would be to just install download and install ffmpeg from within the Audiobookshelf server, if it can't find it. Then the application becomes really portable, and you can just download the executable and put it wherever you want (which also seems intuitive to users), and then no need for an installer at all (also possible to open the default browser to http://localhost:port/ when it's up). What do you think about this? I'm aware this approach is a bit more "rough around the edges". On the other hand, it is more in line with the webby nature of Audiobookshelf. |
Beta Was this translation helpful? Give feedback.
-
@advplyr hi, |
Beta Was this translation helpful? Give feedback.
-
Interesting.
I'm assuming you have not used the installer, since it writes that key and
value.
Also, even if it doesn't exist, I'm perplexed at why this returns null,
since the third parameter of GetValue is the default value which should be
returned if that value does not exist.
Thanks for reporting, I'll investigate further...
…On Mon, Jan 1, 2024 at 11:11 PM advplyr ***@***.***> wrote:
Hey thanks I've been checking it out and getting it set up. One issue I
came across so far is...
Registry.GetValue(@"HKEY_CURRENT_USER\Software\Audiobookshelf", "DataDir",
Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), _appName))
This returns null because the key
"HKEY_CURRENT_USER\Software\Audiobookshelf" doesn't exist in the registry
for me.
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registry.getvalue?view=net-8.0#definition
We can use SetValue if null
—
Reply to this email directly, view it on GitHub
<#2352 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMDFVVZFS3RHQW26RSVBD3YMMRAHAVCNFSM6AAAAAA72YKZT6VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TSOBZGAZTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
Another question that I was contemplating - the installer is not signed. I looked at the costs of obtaining a code signing certificate, and they look prohibitive (~$300 per year). Maybe you already have such a certificate for Audiobookshelf, and if so, could I use it to sign the installer? If not, do you have any suggestions on how to proceed with signing (or just forget about it)? |
Beta Was this translation helpful? Give feedback.
-
I'm not sure if this is the right place to put this, but just wanted to say thank you so much for the native windows version. It's running perfectly for me and showed up right as I was struggling to get it working in Docker. Perfect timing! Great job. |
Beta Was this translation helpful? Give feedback.
-
Hi. My experience installing ABS as a Docker container on Windows was laden with problems:
In short, I believe the expertise bar required for reaching a proper setup with Docker on Windows is too high.
I wanted to solicit some advice as to what's currently missing in order to release this great software on Windows without requiring Docker, and I'll try to work on that (if there's no one else doing it). From my perspective, I see the following:
What else?
Beta Was this translation helpful? Give feedback.
All reactions