From aa051f72de962287b9122006b87702a6614da423 Mon Sep 17 00:00:00 2001
From: Jwalant Modi <164844705+jwalantmodi05@users.noreply.github.com>
Date: Tue, 1 Oct 2024 14:01:34 +0530
Subject: [PATCH] KO-322: Added reasons to logs for unscheduled pods (#315)

* Added reasons to logs for unscheduled pods
---
 internal/controller/cluster/pod.go |  2 +-
 pkg/utils/pod.go                   | 18 +++++++++++-------
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/internal/controller/cluster/pod.go b/internal/controller/cluster/pod.go
index 2b3c93315..5c2deb308 100644
--- a/internal/controller/cluster/pod.go
+++ b/internal/controller/cluster/pod.go
@@ -854,7 +854,7 @@ func (r *SingleClusterReconciler) getIgnorablePods(racksToDelete []asdbv1.Rack,
 			pod := &podList.Items[podIdx]
 
 			if !utils.IsPodRunningAndReady(pod) {
-				if utils.IsPodReasonUnschedulable(pod) {
+				if isPodUnschedulable, _ := utils.IsPodReasonUnschedulable(pod); isPodUnschedulable {
 					pendingPod = append(pendingPod, pod.Name)
 					continue
 				}
diff --git a/pkg/utils/pod.go b/pkg/utils/pod.go
index 5addec1fc..a5b9368a4 100644
--- a/pkg/utils/pod.go
+++ b/pkg/utils/pod.go
@@ -30,11 +30,14 @@ func CheckPodFailed(pod *corev1.Pod) error {
 
 	// if the value of ".status.phase" is "Failed", the pod is trivially in a failure state
 	if pod.Status.Phase == corev1.PodFailed {
-		return fmt.Errorf("pod %s has failed status", pod.Name)
+		return fmt.Errorf("pod %s has failed status with reason: %s and message: %s",
+			pod.Name, pod.Status.Reason, pod.Status.Message)
 	}
 
-	if pod.Status.Phase == corev1.PodPending && IsPodReasonUnschedulable(pod) {
-		return fmt.Errorf("pod %s is in unschedulable state", pod.Name)
+	if pod.Status.Phase == corev1.PodPending {
+		if isPodUnschedulable, reason := IsPodReasonUnschedulable(pod); isPodUnschedulable {
+			return fmt.Errorf("pod %s is in unschedulable state and reason is %s", pod.Name, reason)
+		}
 	}
 
 	// grab the status of every container in the pod (including its init containers)
@@ -73,7 +76,8 @@ func CheckPodImageFailed(pod *corev1.Pod) error {
 
 	// if the value of ".status.phase" is "Failed", the pod is trivially in a failure state
 	if pod.Status.Phase == corev1.PodFailed {
-		return fmt.Errorf("pod has failed status")
+		return fmt.Errorf("pod %s has failed status with reason: %s and message: %s",
+			pod.Name, pod.Status.Reason, pod.Status.Message)
 	}
 
 	// grab the status of every container in the pod (including its init containers)
@@ -198,13 +202,13 @@ func isPodError(reason string) bool {
 	return strings.HasSuffix(reason, "Error")
 }
 
-func IsPodReasonUnschedulable(pod *corev1.Pod) bool {
+func IsPodReasonUnschedulable(pod *corev1.Pod) (isPodUnschedulable bool, reason string) {
 	for _, condition := range pod.Status.Conditions {
 		if condition.Type == corev1.PodScheduled && (condition.Reason == corev1.PodReasonUnschedulable ||
 			condition.Reason == corev1.PodReasonSchedulerError) {
-			return true
+			return true, condition.Message
 		}
 	}
 
-	return false
+	return false, ""
 }