From 0e66eebf22cc27ea422b5847c37fce00c5ab114c Mon Sep 17 00:00:00 2001 From: dylan Date: Thu, 9 Jan 2025 13:35:37 -0800 Subject: [PATCH] remove mention of selenium --- .github/workflows/test-prism-example.yml | 6 ------ .github/workflows/test-quote-example.yml | 6 ------ prism-image-search/tests/README.md | 5 ++--- prism-image-search/tests/requirements.txt | 1 - quote-semantic-search/tests/README.md | 5 ++--- quote-semantic-search/tests/requirements.txt | 1 - 6 files changed, 4 insertions(+), 20 deletions(-) diff --git a/.github/workflows/test-prism-example.yml b/.github/workflows/test-prism-example.yml index ae230b0..0bd9cc7 100644 --- a/.github/workflows/test-prism-example.yml +++ b/.github/workflows/test-prism-example.yml @@ -89,12 +89,6 @@ jobs: sleep 30 # Wait for the server to be ready # TODO come up with a better/faster way to wait for the server to be ready - # Verify Chrome and ChromeDriver Installation - - name: Verify Chrome and ChromeDriver - run: | - google-chrome --version - chromedriver --version - # Run Pytest tests - name: Run Pytest working-directory: ${{ env.WORKING_DIR }} diff --git a/.github/workflows/test-quote-example.yml b/.github/workflows/test-quote-example.yml index 0fc67cb..dd04a7b 100644 --- a/.github/workflows/test-quote-example.yml +++ b/.github/workflows/test-quote-example.yml @@ -104,12 +104,6 @@ jobs: sleep 60 # Wait for the server to be ready # TODO come up with a better/faster way to wait for the server to be ready - # Verify Chrome and ChromeDriver Installation - - name: Verify Chrome and ChromeDriver - run: | - google-chrome --version - chromedriver --version - # Run Pytest tests - name: Run Pytest working-directory: ${{ env.WORKING_DIR }} diff --git a/prism-image-search/tests/README.md b/prism-image-search/tests/README.md index 0a30d57..2013641 100644 --- a/prism-image-search/tests/README.md +++ b/prism-image-search/tests/README.md @@ -11,12 +11,11 @@ Create a virtual environment and install the requirements in requirements.txt. pip install -r requirements.txt ``` -The tests use selenium with the chrome web driver so make sure that is installed on your system. - > [!IMPORTANT] > Run the example app with the IMAGE_DIR environment variable pointing to your test image data. The CI tests use ../container-volumes/prism/images/static/data as it contains one image already. -Run the prism image search example app so that it listens on port 8080. If it is not running on port 8080, you will have to change the tests. +Run the prism image search example app so that it listens on port 8080. +If it is not running on port 8080, you can run the tests with the --app-address option set to the correct address:port. Then run the tests with pytest. ```shell diff --git a/prism-image-search/tests/requirements.txt b/prism-image-search/tests/requirements.txt index 51365bf..c22de59 100644 --- a/prism-image-search/tests/requirements.txt +++ b/prism-image-search/tests/requirements.txt @@ -1,4 +1,3 @@ pytest -selenium requests aerospike-vector-search \ No newline at end of file diff --git a/quote-semantic-search/tests/README.md b/quote-semantic-search/tests/README.md index 12eb9c9..2deca96 100644 --- a/quote-semantic-search/tests/README.md +++ b/quote-semantic-search/tests/README.md @@ -11,9 +11,8 @@ Create a virtual environment and install the requirements in requirements.txt. pip install -r requirements.txt ``` -The tests use selenium with the chrome web driver so make sure that is installed on your system. - -Run the quote search example app so that it listens on port 8080. If it is not running on port 8080, you will have to change the tests. +Run the quote search example app so that it listens on port 8080. +If it is not running on port 8080, you can run the tests with the --app-address option set to the correct address:port. Then run the tests with pytest. ```shell diff --git a/quote-semantic-search/tests/requirements.txt b/quote-semantic-search/tests/requirements.txt index 51365bf..c22de59 100644 --- a/quote-semantic-search/tests/requirements.txt +++ b/quote-semantic-search/tests/requirements.txt @@ -1,4 +1,3 @@ pytest -selenium requests aerospike-vector-search \ No newline at end of file