Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: use sdk provided filesystem util, remove aeproject util implementation #486

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor!: use sdk provided filesystem util, remove aeproject util implementation #486

wants to merge 2 commits into from

Conversation

thepiwo
Copy link
Collaborator

@thepiwo thepiwo commented Jul 28, 2023 •
edited
Loading

closes #474

@thepiwo thepiwo marked this pull request as draft July 28, 2023 09:56
@thepiwo
Copy link
Collaborator Author

thepiwo commented Jul 28, 2023

getFileSystem as exposed by the sdk is async so this will need to be a breaking change or some workaround...

@marc0olo
Copy link
Contributor

getFileSystem as exposed by the sdk is async so this will need to be a breaking change or some workaround...

did you ask @davidyuk why it is async? 🤔

@davidyuk
Copy link
Member

I've used non-blocking file access api, this way nodes process may request multiple files at once

@thepiwo thepiwo force-pushed the refactor/use-sdk-getfilesystem branch from 059f78f to a6bac8a Compare July 31, 2023 07:52
@thepiwo thepiwo changed the title refactor: use sdk provided filesystem util, deprecate aeproject util implementation refactor!: use sdk provided filesystem util, remove aeproject util implementation Jul 31, 2023
@thepiwo thepiwo added this to the v5 - breaking changes milestone Jul 31, 2023
@thepiwo
Copy link
Collaborator Author

thepiwo commented Jul 31, 2023

I made this PR breaking and will gather some more breaking changes eventually for an upcoming v5

@thepiwo thepiwo force-pushed the refactor/use-sdk-getfilesystem branch from a6bac8a to a661796 Compare July 31, 2023 07:54
@thepiwo thepiwo self-assigned this Aug 8, 2023
@thepiwo thepiwo force-pushed the refactor/use-sdk-getfilesystem branch from 05f1ba2 to dcc241e Compare August 24, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thepiwo thepiwo

Labels
breaking; don't merge
Projects
None yet
Milestone
v5 - breaking changes
Development

Successfully merging this pull request may close these issues.

use getFilesystem as exposed by the sdk
3 participants
@thepiwo @marc0olo @davidyuk