Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning an entity with animation animates, it shouldn't #690

Closed
vincentfretin opened this issue May 23, 2023 · 3 comments · Fixed by #799
Closed

Cloning an entity with animation animates, it shouldn't #690

vincentfretin opened this issue May 23, 2023 · 3 comments · Fixed by #799

Comments

@vincentfretin
Copy link
Contributor

If you're cloning an entity with "d" key and the entity has an animation, it animates, it shouldn't. The animations should be paused while in editor mode.

@kfarr
Copy link
Contributor

kfarr commented May 23, 2023

Also keep in mind that in theory animations can be toggled while still in editor mode:

toggleScenePlaying = () => {

@vincentfretin
Copy link
Contributor Author

You can sponsor vincentfretin to expedite this fix. Find other work you can sponsor at https://github.com/c-frame/sponsorship

@vincentfretin
Copy link
Contributor Author

The issue is that we have sceneEl.isPlaying true here

// Trick scene to run the cursor tick.
this.sceneEl.isPlaying = true;

so clone entity play() is executed on the entity
https://github.com/aframevr/aframe/blob/6bf7ee5eb614ca3718c86f651eebc346cd98cc61/src/core/a-entity.js#L232
so the fix would be to call pause() on the entity after the loaded event really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants