Replies: 3 comments 1 reply
-
See #767 |
Beta Was this translation helpful? Give feedback.
-
Plus help to stop using the |
Beta Was this translation helpful? Give feedback.
-
PatternFly team has answered my question. In short, they consider it as a bug and will fix it 🚀 |
Beta Was this translation helpful? Give feedback.
-
|
Answering the question, definitely we should avoid changing the |
Beta Was this translation helpful? Give feedback.
-
Recently, the show password feature landed in the Agama
masterbranch. Now users can check if they typed the intended password. But while using the keyboard to navigate through the installer, I had the feeling that it might be a bit intrusive.Now, the first time users tab after writing the password, the show password action gets the focus, "forcing" them to tab twice to reach the "genuine next form element" (thinking in the revealing action as part of the password input itself). E.g., for jumping to the
Password Confirmationinput when setting the password for a user or theConnectbutton when connecting to a WiFi network.entering_a_password.webm
Admittedly, it is not a (big) issue. Especially considering that it is just the expected behavior: the focus is trapped by the next form element in the document.
However, it made me wonder for a bit more than a second if we should change the
tabIndexorder. Most probably NO, we must not alter such an order without a very strong reason. Moreover, as far as I could check most (if not all) apps/sites implementing this pattern don't do it. And maybe it could be worse for no-sight users, which I don't know how they could know how many times tab to find the show password action.Placing both, the input and the action, at the end of their related form could be a small improvement. It'd make the action less intrusive when using the keyboard. Except for these forms that have the
Password confirmationtoo.Anyhow, I'm just bringing this up here to hear ideas and feedback from you.
Beta Was this translation helpful? Give feedback.
All reactions