Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize_target_repos still referenced #1369

Open
mvidner opened this issue Jun 24, 2024 · 2 comments
Open

initialize_target_repos still referenced #1369

mvidner opened this issue Jun 24, 2024 · 2 comments
Milestone

Comments

@mvidner
Copy link
Contributor

mvidner commented Jun 24, 2024

Reading Agama::Software::Manager code I found a method call that is not defined.
https://github.com/openSUSE/agama/blob/c9a68ce2441a2b73e2af6feae0ee70968e7dca92/service/lib/agama/software/manager.rb#L338
It turns out it is a bug in a recent refactoring, #1329.

@mvidner
Copy link
Contributor Author

mvidner commented Jun 24, 2024

The fix is trivial, the method was renamed to initialize_target to better reflect what it does.
Should we have tests covering this?

@imobachgs
Copy link
Contributor

imobachgs commented Jun 26, 2024

Good catch. It looks like it is related to the registration. And, yes, I think it might be a good idea to have at least a minimal test.

Let's plan to get this fixed in Agama 10.

@imobachgs imobachgs added this to the Agama 10 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants