OptiFine CIT Doesn't support enchantments

[Cxrrlos]

It has converted everything nicely, though my custom textures do not work after the conversion.

The mcpatcher --> cit has changed and become optifine --> cit, though the textures do not work.

(more info on these textures: I had some of when armour was at a certain hp, it changed to look more broken, I also had different textures for sharpness 5 swords)

This was a 1.8 to 1.16.5 conversion, though these textures also worked on 1.12.2 before.

[CoryBorek]

Can you give me one of your CIT .properties files so I can take a look and see if I need to make any changes?

[Cxrrlos]

This is for a diamond sword, when its sharpness 5 it should normally change the texture (Im not sure why the # date and # are there, I didnt put them)

Also, the name of this file is: opsword.properties
(I couldnt just drag it here because it says it doesnt support the .properties file type)

#Mon Jun 28 00:21:28 CEST 2021
items=276
enchantmentLevels=5
type=item
enchantmentIDs=16
texture=opsword.png

[CoryBorek]

And where is opsword.png located? in the same folder as opsword.properties?

[Cxrrlos]

Yes, I believe its all in the same folder.
The mcpatcher --> cit is now optifine --> cit, but all the pngs and .properties are in the same cit folder like they used to be.

[CoryBorek]

so the pngs and properties are in mcpatcher --> cit and not optifine --> cit?

[Cxrrlos]

now there is no folder called mcpatcher, to get to the cit folder, I do assets --> minecraft --> optifine --> cit

[CoryBorek]

oh okay. there may have been changes to optifine then. I know this system used to work in 1.13

[Cxrrlos]

So, is there any way to get it to work? Even if its manually?

[CoryBorek]

I'd have to look into the changelogs for optifine. If it's something fixable, I can implement changes relatively easily

[CoryBorek]

Quick question, Try removing the .png from the image replacement text and see what happens?

[Cxrrlos]

Im not sure what you mean by: "image replacement text". Do you mean changing the file name to not be a .png?

I have removed the .png and edited the .properties document to look for the new file name.
(So, in the .properties I have changed it to texture=opsword)

It still doesnt seem to be working.

[CoryBorek]

Don't remove the .png from the file itself, just the reference in the .properties file

[Cxrrlos]

It still is not working

[CoryBorek]

I'll have to look at the optifine changelog then.

[CoryBorek]

Update: The software doesn't currently change enchantment ids. That will probably have to be fixed

[Cxrrlos]

Though, I think this is not only enchantments because none of the others change. ( I have one for when armour was at a certain hp, it changed to look more broken )

[CoryBorek]

This will not be worked on until #68 is finished. I'd like all the OptiFine and other mod changes to be moved over to Extensions, as that will make it easier for other mods to be worked on. Will only fix any major issues of stuff currently implemented.

[CoryBorek]

Most likely will move away from supporting CIT in the future. Will leave open until a final decision is made.

[lowercasebtw]

I hope not, a lot of 1.8 packs use CIT and this converter would be huge for the 1.8 community, already shared it to a lot of people I know, including 1.8 pack makers