Snakecase fields in records should be turned into camelCase

[eeue56]

Example input:

  Banana:
    type: object
    required:
      - banana_id
    properties:
      banana_id:
        type: string

right now generates:

type alias BananaRecord = 
  {  banana_id: String
  }

decodeBanana = ...
  ... 
  |> required "banana_id"
  ...

It should instead generate:

type alias BananaRecord = 
  {  bananaId: String
  }

decodeBanana = ...
  ... 
  |> required "banana_id"
  ...

[ahultgren]

I think this is a nice-to-have, since _, while not idiomatic, works. Also there's the issue of avoiding name collisions. Consider:

  Banana:
    type: object
    properties:
      banana_id:
        type: string
      bananaId:
        type: string

which would be valid swagger.

[eeue56]

I would argue that that example should actually be invalid swagger. If you have to things with the same name, the only difference being camelCase and camel_case, then you've duplicated the fields and made the API inconsistent

[ahultgren]

I agree it's a bad schema, but it's nonetheless a valid spec. Swagger is very unopinionated on how you name your fields. I suppose it's a separate issue though, since sanitization can already cause collisions.

[eeue56]

I would think the ideal approach would be to make swagger-elm warn you when your API contains underscores, and provide a flag for auto-converting it to camelCase

[ahultgren]

That sounds like a good solution