Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert self.ptc & self.delpc usage in dyn_core or decide to remove them #322

Open
FlorianDeconinck opened this issue Sep 13, 2022 · 0 comments
Labels
enhancement New feature or request refactor Code clean up or deeper refactoring tasks

Comments

@FlorianDeconinck
Copy link
Contributor

A memory leak was introduced by VRAM pooling due to the particular pattern in using self.ptc and self.delpc as return value read of C_SW. Those where remove in PR #319 to plug the leak.
A soon-to-be released version of DaCe deals with it at the source and once merged we could remove the workaround, which to use the internal C_SW ptc and delpc.
Another option to do away with the dyn_core allocated ones, since this only adds a copy

@FlorianDeconinck FlorianDeconinck added enhancement New feature or request refactor Code clean up or deeper refactoring tasks labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Code clean up or deeper refactoring tasks
Projects
None yet
Development

No branches or pull requests

1 participant