Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Multiple potentials for a calculation #38

Open
JPchico opened this issue Jun 10, 2022 · 2 comments
Open

✨ Multiple potentials for a calculation #38

JPchico opened this issue Jun 10, 2022 · 2 comments

Comments

@JPchico
Copy link
Collaborator

JPchico commented Jun 10, 2022

In the current implementation in the develop branch only one potential can be given for a calculation.

This limits the flexibility of what can be done with the plugin. However, applying a "potential family" like is done in the DFT codes is not possible due to the number of possible potentials that exist. Hence another solution is needed.

One would need to add a dynamical namespace for the potential so that one allows more than one entry, while also specifying which potential acts over which atom type.

@JPchico
Copy link
Collaborator Author

JPchico commented Feb 22, 2023

Something else that comes as a result of this is that the pair_coeff probably needs to be added to the potential_parameters, in someway like this

potential_parameters = {
    'pair_coeff': {
        'Al': ['1*2', '2'],
        'Si': ['*', '*'],
    }
}

One would need to check that the atoms defined there are present in the given potentials, or otherwise raise a warning.

In general for the dynamic inputs part one needs to have the following

  1. Check that all the potentials given have the same pair_style
  2. Group by potential file, to make sure that if the same file is used for several atoms only one line is written and not several
  3. Change the input generation so that when the atom which is being treated is given one takes the key of the input_namespace
  4. Check that only elements are given as keys in the input_namespace
  5. By default if nothing is given the pair_coeff should be set to * *

@JPchico JPchico removed this from the Refactoring and generalization milestone Mar 3, 2023
@JPchico
Copy link
Collaborator Author

JPchico commented Mar 3, 2023

This is going to be something to be discussed in a post-release patch, as it is not critical right now and it should not affect other cases when one is using only one potential file.

@JPchico JPchico changed the title Multiple potentials for a calculation ✨ Multiple potentials for a calculation May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant