Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The get_pymatgen_structure doesn't allow pbc != 3D #6280

Closed
bastonero opened this issue Feb 8, 2024 · 0 comments · Fixed by #6281
Closed

The get_pymatgen_structure doesn't allow pbc != 3D #6280

bastonero opened this issue Feb 8, 2024 · 0 comments · Fixed by #6281

Comments

@bastonero
Copy link
Contributor

The get_pymatgen_structure has a strict check on the periodic boundary conditions, raising errors when pbc != (True, True, True). This means that any pbc different from 3D would raise error. As far as I saw in pymatgen core modules, they actually allow for different pbc (e.g. the lattice class allows any pbc).

So one should define a Lattice instance instead of passing directly the self.cell, which is simply array like. The Lattice class also provides pbc in input, so it should be straightforward.

I don't know about older version of pymatgen, maybe they didn't have this class before? Or maybe it wasn't realised at the time?

Originally posted by @bastonero in aiidateam/aiida-quantumespresso#996 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant