Don't raise exception for successful verdi archive import -n

[GeigerJ2]

When doing a dry-run of an archive import, the import_archive function raises the ImportTestRun('test run complete') exception, resulting in a user-facing Critical: output. Is there any particular reason for this behavior, rather than just a Report: that the dry-run is done?

Relevant code here:

aiida-core/src/aiida/cmdline/commands/cmd_archive.py

Lines 516 to 525 in be0db3c

	try:
	_import_archive(archive_path, archive_format=archive_format, **import_kwargs)
	except Exception as sub_exception:
	_echo_exception(
	f'an exception occurred while trying to import the migrated archive {archive}', sub_exception
	)
	else:
	_echo_exception(f'an exception occurred while trying to import the archive {archive}', exception)
	except Exception as exception:
	_echo_exception(f'an exception occurred while trying to import the archive {archive}', exception)

aiida-core/src/aiida/tools/archive/imports.py

Lines 198 to 200 in be0db3c

	if test_run:
	# exit before we write anything to the database or repository
	raise ImportTestRun('test run complete')

[sphuber]

s there any particular reason for this behavior, rather than just a Report: that the dry-run is done?

Don't think so. Likely just an oversight. We should really just be catching the ImportTestRun exception separately and issues an echo_success message

[GeigerJ2]

Alright, cool! Should be done by #6403.