You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it possible to simplify this, somehow?
Right now, we need to update uv version manually in ~4 places.
Maybe one idea could be to have a hook on pre-commit to read the required version from pyproject.toml and if that doesn't match with other places (action.yml, .readthedocs.yml, etc), would automatically update them.
After #6699 is merged, we'll have 4 places to maintain uv version
pyproject.toml - this one enforces a minimum uv version to ensure the consistency of the lockfile
.pre-commit-config.yaml - specifies uv version that is used to check the lockfile is up-to-date
.github/actions/install-aiida-core/action.yml - used to install aiida-core dependencies for most of the CI jobs
.readthedocs.yml for doc build
It's not clear how to reduce this number. I think ultimately, as uv matures and stabilizes (especially its lockfile implementation) we can simply always install the latest version in CI. This is what many others are doing.
I don't think it's worth it to somehow automate this. Updating version in four places is for sure annoying, but at the same time, if one forgets, there is a very clear error. If we bump minimum version in pyproject.toml, but forget to update it in docs build, it will fail with an error stating that the uv version is not satisfied.
Originally posted by @khsrali in #6699 (comment)
The text was updated successfully, but these errors were encountered: