{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":722657082,"defaultBranch":"master","name":"rdma-core","ownerLogin":"aikuchin","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-11-23T16:14:12.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/8108603?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1700756607.0","currentOid":""},"activityList":{"items":[{"before":"9ce8974a5c346e2fe09143db43f0b7b8547fbc7d","after":"5814d7842b85451cc29186844c022785835c3565","ref":"refs/heads/fix_leak_in_add_to_portlid_hash","pushedAt":"2023-11-28T11:52:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aikuchin","name":null,"path":"/aikuchin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8108603?s=80&v=4"},"commit":{"message":"ibnetdisc: Fix leak in add_to_portlid_hash\n\nWhen the duplicate port is added to the map cl_qmap_insert() returns pointer\nto existing value and the new entry is left unused that results in leak:\n\n==1606814== 2,624 bytes in 41 blocks are definitely lost in loss record 1 of 1\n==1606814== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)\n==1606814== by 0x5174B59: add_to_portlid_hash (ibnetdisc.c:704)\n==1606814== by 0x517638E: recv_port_info (ibnetdisc.c:379)\n==1606814== by 0x51789B0: process_one_recv (query_smp.c:200)\n==1606814== by 0x5178EF7: process_mads (query_smp.c:276)\n==1606814== by 0x51755E7: ibnd_discover_fabric (ibnetdisc.c:817)\n==1606814== by 0x109229: main (in /vagrant/go/gpu/ib-ict-manager/a.out)\n\nThe solution is to free new item if it was not added to the map.\n\nFixes: 16168163317b (\"ibdiags: Use cl_qmap instead of glib hashtable\")\n\nSigned-off-by: Anton Kuchin ","shortMessageHtmlLink":"ibnetdisc: Fix leak in add_to_portlid_hash"}},{"before":"3d5b3bb36a6153ed433bf6c9f2fe82b800ffdbe1","after":"9ce8974a5c346e2fe09143db43f0b7b8547fbc7d","ref":"refs/heads/fix_leak_in_add_to_portlid_hash","pushedAt":"2023-11-28T11:38:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aikuchin","name":null,"path":"/aikuchin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8108603?s=80&v=4"},"commit":{"message":"ibnetdisc: Fix leak in add_to_portlid_hash\n\nWhen the duplicate port is added to the map cl_qmap_insert() returns pointer\nto existing value and the new entry is left unused that results in leak:\n\n==1606814== 2,624 bytes in 41 blocks are definitely lost in loss record 1 of 1\n==1606814== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)\n==1606814== by 0x5174B59: add_to_portlid_hash (ibnetdisc.c:704)\n==1606814== by 0x517638E: recv_port_info (ibnetdisc.c:379)\n==1606814== by 0x51789B0: process_one_recv (query_smp.c:200)\n==1606814== by 0x5178EF7: process_mads (query_smp.c:276)\n==1606814== by 0x51755E7: ibnd_discover_fabric (ibnetdisc.c:817)\n==1606814== by 0x109229: main (in /vagrant/go/gpu/ib-ict-manager/a.out)\n\nThe solution is to free new item if it was not added to the map.\n\nFixes: 16168163317b (ibdiags: Use cl_qmap instead of glib hashtable)\n\nSigned-off-by: Anton Kuchin ","shortMessageHtmlLink":"ibnetdisc: Fix leak in add_to_portlid_hash"}},{"before":null,"after":"3d5b3bb36a6153ed433bf6c9f2fe82b800ffdbe1","ref":"refs/heads/fix_leak_in_add_to_portlid_hash","pushedAt":"2023-11-23T16:23:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aikuchin","name":null,"path":"/aikuchin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8108603?s=80&v=4"},"commit":{"message":"ibnetdisc: Fix leak in add_to_portlid_hash\n\nWhen the duplicate port is added to the map cl_qmap_insert() returns pointer\nto existing value and the new entry is left unused that results in leak:\n\n==1606814== 2,624 bytes in 41 blocks are definitely lost in loss record 1 of 1\n==1606814== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)\n==1606814== by 0x5174B59: add_to_portlid_hash (ibnetdisc.c:704)\n==1606814== by 0x517638E: recv_port_info (ibnetdisc.c:379)\n==1606814== by 0x51789B0: process_one_recv (query_smp.c:200)\n==1606814== by 0x5178EF7: process_mads (query_smp.c:276)\n==1606814== by 0x51755E7: ibnd_discover_fabric (ibnetdisc.c:817)\n==1606814== by 0x109229: main (in /vagrant/go/gpu/ib-ict-manager/a.out)\n\nThe solution is to free new item if it was not added to the map.\n\nFixes: 161681633 (ibdiags: Use cl_qmap instead of glib hashtable)\n\nSigned-off-by: Anton Kuchin ","shortMessageHtmlLink":"ibnetdisc: Fix leak in add_to_portlid_hash"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0yOFQxMTo1MjozMS4wMDAwMDBazwAAAAO5v_SI","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0yOFQxMTo1MjozMS4wMDAwMDBazwAAAAO5v_SI","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0yM1QxNjoyMzoyNy4wMDAwMDBazwAAAAO2RMtc"}},"title":"Activity ยท aikuchin/rdma-core"}