Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable HTTPS #239

Open
obilodeau opened this issue Sep 17, 2024 · 1 comment
Open

Configurable HTTPS #239

obilodeau opened this issue Sep 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@obilodeau
Copy link
Contributor

I am running AIL framework behind a TLS-terminating proxy that is integrated with letsencrypt for automatically renewed certificates. I do not need it to provide its certificates. (It's actually the tailscale serve proxy a very nice feature!)

I tried looking at the configuration to make this happen but it doesn't seem supported. In the end, this did it:

# git diff
diff --git a/var/www/Flask_server.py b/var/www/Flask_server.py
index 7e6aa64e..3c58cc67 100755
--- a/var/www/Flask_server.py
+++ b/var/www/Flask_server.py
@@ -326,4 +326,5 @@ clear_git_meta_cache()
 # ============ MAIN ============
 
 if __name__ == "__main__":
-    app.run(host=host, port=FLASK_PORT, threaded=True, ssl_context=ssl_context)
+    app.run(host=host, port=FLASK_PORT, threaded=True)

Are you interested in getting a patch that would add a [Flask].https parameter to core.cfg that would add the context (default) or not?

@Terrtia Terrtia added the enhancement New feature or request label Sep 18, 2024
@Terrtia
Copy link
Member

Terrtia commented Sep 18, 2024

Hi @obilodeau !

Pull requests are welcome !
Adding an option to disable the ssl_context make sense.
You can use the ConfigLoader to load the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants