You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The module aiohttp-requests does some weird monkey patching that causes aiodocker to fail in inscrutable ways when trying to read/write to stdin/stdout using attach().
# Patch ClientResponse.read to release immediately after read so we don't need to worry about that / use context manager_read_only=aiohttp.client_reqrep.ClientResponse.readasyncdef_read_and_release(self): # noqatry:
data=await_read_only(self)
finally:
self.close()
returndataaiohttp.client_reqrep.ClientResponse.read=_read_and_release
Expected behaviour: can read/write to stdin/stdout using attach()
Actual behaviour: stream._init() fails in inscrutable ways
Suggestion
My suggestion is to document this fact in the documentation. aiohttp-requests is a popular package.
The problem is subtle because most of aiodocker works; it's just the attach() part that doesn't work.
The text was updated successfully, but these errors were encountered:
Long story short
The module
aiohttp-requests
does some weird monkey patching that causes aiodocker to fail in inscrutable ways when trying to read/write to stdin/stdout using attach().https://pypi.org/project/aiohttp-requests/
This is the monkey patch that causes problems:
attach()
stream._init()
fails in inscrutable waysSuggestion
My suggestion is to document this fact in the documentation.
aiohttp-requests
is a popular package.The problem is subtle because most of
aiodocker
works; it's just theattach()
part that doesn't work.The text was updated successfully, but these errors were encountered: