[WIP] 🏷️ Add type hints #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self._conn = None | ||
|
|
||
|
|
||
| class _PoolConnectionContextManager: |
Check failure
Code scanning / CodeQL
`__iter__` method returns a non-iterator
| def setoutputsizes(self, *args): | ||
| """Does nothing, required by DB API.""" | ||
|
|
||
| async def nextset(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
| logger.info("%r", args) | ||
| return self._rowcount | ||
|
|
||
| async def executemany(self, query, args): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
| row = self._conv_row(row) | ||
| return row | ||
|
|
||
| async def fetchone(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request adds type hints to aiomysql, making it easier for developers to understand the API and to use the library in their code. Due to cyclic dependencies between the cursor and connection classes, two files have been merged into one. Additionally, the _ContextManager class has been generalized as much as possible to improve code reuse and maintainability.
Related issue number
#707
Checklist
CHANGESfolder