Replies: 1 comment 1 reply
-
|
Seems reasonable -- are you interested in submitting a pull request with this change? |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Can do 👍 |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It would be very convenient if DictionaryTextProvider conformed to Equatable. Because its
valuesproperty is internal, it is impossible to make it equatable in projects that use Lottie.It's not a big deal to create your own DictionaryTextProvider, but then you have to deal with name collision when importing Lottie. I think it makes sense to add an equatable conformance here, as I don't believe there will be many changes to this class, and so the maintenance burden is quite low.
Beta Was this translation helpful? Give feedback.
All reactions