Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_full_name optional on AbstractBaseUser #267

Open
rcjohnson opened this issue May 23, 2023 · 1 comment
Open

get_full_name optional on AbstractBaseUser #267

rcjohnson opened this issue May 23, 2023 · 1 comment

Comments

@rcjohnson
Copy link

user_info = dict(username=user.get_username(), name=user.get_full_name())
-> references get_full_name(), but per https://docs.djangoproject.com/en/4.2/topics/auth/customizing/ get_full_name is optional. Either update the documentation for Airbrake to make it clear that this method must be implemented, or better, update this line to check for the method and workaround cases when get_full_name is not implemented (e.g. teams with custom user models.)

@rcjohnson
Copy link
Author

For context, if this method is missing Airbrake throws an error when trying to log errors seemingly preventing it from actually logging to Airbrake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant