Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClientMetadata to RemoteStorageFetchInfo #32

Closed
jeqo opened this issue Jun 26, 2023 · 1 comment
Closed

Add ClientMetadata to RemoteStorageFetchInfo #32

jeqo opened this issue Jun 26, 2023 · 1 comment
Labels
enhancement Stale tiered storage Issues related to Tiered Storage

Comments

@jeqo
Copy link

jeqo commented Jun 26, 2023

Once Tiered Storage is deployed, it will be important to understand how remote data is accessed, and which patterns emerge on each deployment.

To do this, tiered storage logs should provide enough context about which client is fetching which partition/offset range and when.

At the moment, Client metadata is not propagated to the tiered-storage framework. To fix this, RemoteStorageFetchInfo can be extended with Optional[ClientMetadata] available on FetchParams, and have this bits of data available to improve the logging when fetching.

@jeqo jeqo added enhancement tiered storage Issues related to Tiered Storage labels Jun 26, 2023
@jeqo
Copy link
Author

jeqo commented Jul 3, 2023

@github-actions github-actions bot added the Stale label Oct 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Stale tiered storage Issues related to Tiered Storage
Projects
None yet
Development

No branches or pull requests

1 participant