Refactor code to dynamically generate themes and cards #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaximilianoCabreraP This is nice update, but it will change the route of every card, you have to rename each file in this PR to keep the route intact. |
|
It's not necessary; the route runs fine and adapts everything. Here is the URL where I'm running it on my localhost for you to review: https://rna-vegas-closing-senators.trycloudflare.com |
|
i saw the issue, my bad 🙏 |
|
@MaximilianoCabreraP I will close this PR in 24 hours or please make the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some changes to simplify how we handle themes and cards in the project. Instead of manually adding each card one by one, the code now imports them dynamically. This means any new card added to the ./src/cards directory gets picked up automatically—no extra coding required!
Olso i update the README.md.
closes #108