Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hard-code provider gateway address #15

Open
boz opened this issue Feb 20, 2022 · 2 comments
Open

Don't hard-code provider gateway address #15

boz opened this issue Feb 20, 2022 · 2 comments

Comments

@boz
Copy link
Contributor

boz commented Feb 20, 2022

This should be a variable:

https://github.com/ovrclk/helm-charts/blob/b52f46016de4a4516c6a4711fecead0cb58d7bbf/charts/akash-provider/templates/configmap-boot.yaml#L64

@sacreman
Copy link
Contributor

sacreman commented Mar 9, 2022

We got the docs to the point where we tell people to "create these dns entries under the domain you want to use". I agree this could be a variable but then it adds extra complication to the docs.

@arno01
Copy link
Contributor

arno01 commented Mar 10, 2022

We can add a variable which, if not set, would default to what we already have provider.{{ .Values.domain }}.
This way users can easily change "provider." by passing the helm variables, instead of having to change a hardcoded "provider." bit.

And we can mention in the docs just one line:
--set dns.provider=provider.<domain>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants