Simplify withdraw and withdrawAll by sending the funds directly to withdrawalRecipient

[cleanunicorn]

Description

review-casinoverse-land-2022-08/code/contracts/Land.sol

Lines 249 to 260 in 0c7e33d

	/**
	* @dev Throws if withdrawalRecipient is invalid
	*
	* @param _withdrawalRecipient withdrawalRecipient passed by caller
	*/
	modifier isValidRecipient(address _withdrawalRecipient) {
	require(
	withdrawalRecipient == _withdrawalRecipient,
	"Invalid Recipient"
	);
	_;
	}

There's only 1 valid account that funds can be sent to. Thus, the argument _withdrawalRecipient is not required.

review-casinoverse-land-2022-08/code/contracts/Land.sol

Line 669 in 0c7e33d

function withdraw(address _withdrawalRecipient, uint256 _amount)

review-casinoverse-land-2022-08/code/contracts/Land.sol

Line 669 in 0c7e33d

function withdraw(address _withdrawalRecipient, uint256 _amount)

Recommendation

Remove modifiers, send directly to _withdrawalRecipient