Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some methods should be locked while the sale is active #6

Open
cleanunicorn opened this issue Aug 8, 2022 · 0 comments
Open

Some methods should be locked while the sale is active #6

cleanunicorn opened this issue Aug 8, 2022 · 0 comments

Comments

@cleanunicorn
Copy link
Member

Description

The owner has permission to change some important parameters while the sale is active:

The parameters controlled by these methods are very important for the users.

A few examples of why these methods should be inactive while the sale is happening:

  • owner can change the token price
  • owner can change the merkle root
  • owner can change the token limit sale per address

The users assume the contract they are interacting with is safe. This includes coding bugs and centralization issues, such as the owner being able to change the price mid-auction or changing the token limit sale.

Recommendation

Do not allow the methods to be called while the sale is active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant