Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate sslContext doesn't override a configured trustManager #1674

Open
raboof opened this issue Aug 31, 2022 · 0 comments
Open

Validate sslContext doesn't override a configured trustManager #1674

raboof opened this issue Aug 31, 2022 · 0 comments
Labels

Comments

@raboof
Copy link
Member

raboof commented Aug 31, 2022

Short description

When your GrpcClientSettings specifies both an sslContext and a trustManager, Akka gRPC will use the sslContext to create the TLS connection and ignore the trustManager.

This might be non-obvious, and worst case cause too many CA's to be trusted. Perhaps we should add a validation that checks these settings are not both set. That validation could be in the Settings object (imposing a strict order in which settings are applied) or where the settings are used (causing a somewhat less helpful stack trace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant