Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement test runner cancellation #12

Open
IgorFedchenko opened this issue Feb 7, 2020 · 2 comments
Open

Implement test runner cancellation #12

IgorFedchenko opened this issue Feb 7, 2020 · 2 comments
Assignees
@Arkatufus
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@IgorFedchenko
Copy link
Contributor

TestExecutor has Cancel method used by dotnet test to perform cancellation. VS will use it to stop tests too.

It is no-op now, but should cancel all running nodes (I guess by killing processes) and stop MNTR.
@IgorFedchenko IgorFedchenko added the enhancement New feature or request label Feb 8, 2020
@IgorFedchenko IgorFedchenko added this to the v1.1.0 milestone Feb 13, 2020
@Aaronontheweb
Copy link
Member

@Arkatufus how is this handled currently in the NuGet package we've published?

@Aaronontheweb
Copy link
Member

To implement this:

  • Iterate through nodeProcesses and call Process.Kill on each of them.
  • Write the appropriate "test run cancelled" message to the test output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arkatufus Arkatufus

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@Aaronontheweb @Arkatufus @IgorFedchenko