Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for preserving type info throughout serialization/deserialization process #334

Open
danne931 opened this issue Nov 11, 2023 · 1 comment · May be fixed by #335
Open

Add support for preserving type info throughout serialization/deserialization process #334

danne931 opened this issue Nov 11, 2023 · 1 comment · May be fixed by #335

Comments

@danne931
Copy link

Expected behavior
I should be able to use a custom serializer defined with SerializerWithStringManifest or Serializer when IncludeManifest = true and have the appropriate type info passed into FromBinary.

Actual behavior
If using a custom serializer defined with Serializer when IncludeManifest = true, the manifest type passed into FromBinary is not correct.
If using a custom serializer defined with SerializerWithStringManifest, the manifest type string provided in my custom serializer's Manifest method is not passed into the manifest parameter of FromBinary.

Additional context
I am using F# so fixing this so I can define a custom serializer to serialize/deserialize messages with a 3rd party library would be quite helpful.

@danne931
Copy link
Author

Potential fix:
#335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant