Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iframes with allowFullScreen triggers warning #122

Open
adrianhelvik opened this issue Nov 3, 2020 · 1 comment
Open

Iframes with allowFullScreen triggers warning #122

adrianhelvik opened this issue Nov 3, 2020 · 1 comment

Comments

@adrianhelvik
Copy link

index.js:1 Warning: Received the string true for the boolean attribute allowFullScreen. Although this works, it will not work as expected if you pass the string "false". Did you mean allowFullScreen={true}?

Warning generated by this html: <iframe allowfullscreen="true"></iframe>
@aknuds1
Copy link
Owner

aknuds1 commented Nov 3, 2020

I don't really know how to fix this. Can you provide a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aknuds1 @adrianhelvik