Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify construction of "kustomizeImages" #244

Open
krancour opened this issue Feb 16, 2024 · 0 comments
Open

simplify construction of "kustomizeImages" #244

krancour opened this issue Feb 16, 2024 · 0 comments

Comments

@krancour
Copy link
Member

Requires change similar to akuity/kargo#1481

Here in Kargo Render, the kustomize binary isn't invoked directly, but the same complication removed by akuity/kargo#1481 can be removed in Kargo Render's use of the Argo CD repo server.

func Render(
	ctx context.Context,
	path string,
	images []string,
) ([]byte, error) {
	kustomizeImages := make(argoappv1.KustomizeImages, len(images))
	for i, image := range images {
		addr, _, _ := strings.SplitLast(image, ":")
		kustomizeImages[i] =
			argoappv1.KustomizeImage(fmt.Sprintf("%s=%s", addr, image))
	}
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant