You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was raised by @krancour: "I only just noticed this now and didn't notice in #1477 -- does this path filtering only work with the NewestFromBranch commit selection strategy? That appears to be the case and I'm now wondering why that is. (We can open a separate issue for this if we determine this was a mistake.)"
I started implementation of path filters aimed at only the NewestFromBranch CommitSelectionStrategy. Now after rethinking I believe it should not be restricted to the mentioned CommitSelectionStrategy but instead apply to all of the strategies. No matter if tag filters are used in a Git subscription - that should not prevent the option of additionally using path filters. In fact having both filtering types combined makes it more flexible in my opinion.
This was raised by @krancour: "I only just noticed this now and didn't notice in #1477 -- does this path filtering only work with the NewestFromBranch commit selection strategy? That appears to be the case and I'm now wondering why that is. (We can open a separate issue for this if we determine this was a mistake.)"
I started implementation of path filters aimed at only the NewestFromBranch CommitSelectionStrategy. Now after rethinking I believe it should not be restricted to the mentioned CommitSelectionStrategy but instead apply to all of the strategies. No matter if tag filters are used in a Git subscription - that should not prevent the option of additionally using path filters. In fact having both filtering types combined makes it more flexible in my opinion.
@krancour @hiddeco what do you think? If approved I'll take it.
The text was updated successfully, but these errors were encountered: