Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Warehouse Git subscription path filters to all CommitSelectionStrategy types #1896

Closed
maksimstankevic opened this issue Apr 26, 2024 · 2 comments · Fixed by #1918
Closed

Comments

@maksimstankevic
Copy link
Contributor

This was raised by @krancour: "I only just noticed this now and didn't notice in #1477 -- does this path filtering only work with the NewestFromBranch commit selection strategy? That appears to be the case and I'm now wondering why that is. (We can open a separate issue for this if we determine this was a mistake.)"

I started implementation of path filters aimed at only the NewestFromBranch CommitSelectionStrategy. Now after rethinking I believe it should not be restricted to the mentioned CommitSelectionStrategy but instead apply to all of the strategies. No matter if tag filters are used in a Git subscription - that should not prevent the option of additionally using path filters. In fact having both filtering types combined makes it more flexible in my opinion.

@krancour @hiddeco what do you think? If approved I'll take it.

@krancour
Copy link
Member

@maksimstankevic agreed.

@maksimstankevic
Copy link
Contributor Author

Sent #1918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment