-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete/List command for Stage #484
Conversation
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 58 58
Lines 4271 4271
=======================================
Hits 2114 2114
Misses 2070 2070
Partials 87 87 |
Signed-off-by: Sunghoon Kang <[email protected]>
Signed-off-by: Sunghoon Kang <[email protected]>
bce8543
to
852cc74
Compare
Implementation looks fine, but I have a concern about the UX... In #489, for PromotionPolicies, I see a Here I see I think we need to pick one style and apply it consistently: Either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming #488 will address the minor concerns that were raised.
This PR adds Delete/List command for Stage to CLI.