make default controller work exclusively on unlabeled resources #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krancour
requested review from
alexmt,
devholic,
gdsoumya,
jessesuen,
kencochrane and
rbreeze
as code owners
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 51.18% 51.77% +0.58%
==========================================
Files 51 52 +1
Lines 4085 4095 +10
==========================================
+ Hits 2091 2120 +29
+ Misses 1910 1890 -20
- Partials 84 85 +1
|
krancour
force-pushed
the
krancour/default-controller
branch
from
80ab645
to
4fa92a5
Compare
gdsoumya
requested changes
Jul 24, 2023
Signed-off-by: Kent <[email protected]>
Signed-off-by: Kent <[email protected]>
krancour
force-pushed
the
krancour/default-controller
branch
from
4fa92a5
to
ad7ef44
Compare
krancour
changed the title
jessesuen
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR: Default controller operated on all resources.
After this PR: Default controller operates exclusively on unlabeled resources.