-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal-versions: freetype-rs dependency is too low #44
Comments
I can't actually reproduce this? Building crossfont and Alacritty works for me just fine with |
0.4.1 is even worse for (I was testing with 0.4.0 accidentially, because that is the minimum version sctk-alacritty depends on):
I have attached the Cargo.lock generated on my system, hopefully that helps? |
Huh it works now, by which I mean it doesn't build. I must have forgotten to delete the That said, do you actually have suggestions to fix this issue specifically? Of course we should have minimal versions in our dependency tree that actually build, but that doesn't help you, right? Or do you plan to just bump the patch version to 0.4.3, despite technically being able to build with 0.4.2 too? |
What I want to get out of this is being able to build smithay with minimal-versions, which mean this fix would have to propagate through to winit...
(I could instead disable the Also yes: Technically we can build with 0.4.1, the code is not wrong. What is wrong are its dependencies so in my opinion we cannot actually build with 0.4.1 and bumping the patch version is the correct fix. |
Considering Rust's stance on running with minimal versions, I'd consider this inaccurate. Generally I think you're going to have a tough time getting a guarantee to always be able to build with minimal versions. While the |
In practice this is true, but I want to try and encourage more people to fix this in their crates.
Thanks for forwarding this as necessary. |
Should be fixed. |
Compiling crossfont with
-Z minimal-versions
fails with:I assume
crossfont
needs a higherfreetype-rs
version than the minimum specified in the Cargo.toml, because runningcargo update -p freetype-sys
fixes the error.The text was updated successfully, but these errors were encountered: