Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dictionary] no spaces allowed in search term #1444

Closed
martinengelke opened this issue Sep 27, 2024 · 7 comments
Closed

[dictionary] no spaces allowed in search term #1444

martinengelke opened this issue Sep 27, 2024 · 7 comments
Assignees

Comments

@martinengelke
Copy link

martinengelke commented Sep 27, 2024

Package source

GitHub

App logs

MacOS

Current Behavior

If I want to search for let's say "gear box" it will show me the preview on the bottom, but won't launch the dictionary app on pressing return.

Expected Behavior

open the dictionary app and insert e.g. "gear box" with spaces included.

Anything else?

Bildschirmfoto 2024-09-27 um 14 07 31

Would be nice to have a proper overview, since the actual one is not aware of line breaks from dictionary file:

Bildschirmfoto 2024-09-27 um 14 08 24

Edit: the actual one is aware of line breaks, since beolingus extension of dictionary app is not swallowing the linbreaks:

Bildschirmfoto 2024-09-27 um 15 01 51

Maybe some dictionaries define other line break conventions or either have none ^^?

Anyway if I hover over the definition it could bring up the macOS built-in "look up feature" or a QuickLook like it does for Apples Spotlight Definitions, when hitting space key.
-> A one liner is maybe it a bit overwhelming in some cases ;/

suggestion: maybe ALT menu for each entry could bring up a bigger overview?

p.s.: searching through my offline Wikipedia would be so much cooler in that way :P

@ManuelSchneid3r
Copy link
Member

Anything else?

Bildschirmfoto 2024-09-27 um 14 07 31

By the way I had this bug on Linux but not on macOS. Which model is this?

@ManuelSchneid3r
Copy link
Member

maybe ALT menu for each entry could bring up a bigger overview?

there are plans for a details view.

@martinengelke
Copy link
Author

By the way I had this bug on Linux but not on macOS. Which model is this?

What do you mean by model?
I am running macOS 14.5

@martinengelke
Copy link
Author

If you mean the dictionary "Termninology", it's that one:

https://agiletortoise.com/terminology/mac/

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Sep 30, 2024

What do you mean by model?

the machine. because i assume this bug is harware dependent.

Bildschirmfoto 2024-09-30 um 15 55 37

@martinengelke
Copy link
Author

MacBook Pro M3 Pro 18 GB
14" Nov. 2023

Es flackert ab und an, was ich erst beobachte seitdem ich dein (wirklich schönes) Theme benutze.

@ManuelSchneid3r
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants