Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[emoji] Should (optionally?) only show up if triggered #1467

Closed
AshesITR opened this issue Oct 24, 2024 · 2 comments
Closed

[emoji] Should (optionally?) only show up if triggered #1467

AshesITR opened this issue Oct 24, 2024 · 2 comments
Assignees

Comments

@AshesITR
Copy link

Package source

github, current main @ e4af117f

App logs

Most likely not helpful, since the behavior is invisible in the logs.

NB: There are warnings generated by some emoji:

21:33:36 [debg:albert] 22 ms spent loading plugin 'python.emoji'
21:33:36 [debg:albert] 0 ms spent instanciating plugin 'python.emoji'
21:33:36 [warn:albert] Skipping index entry '✨'. Tokenization of '*' yields empty set.
21:33:36 [warn:albert] Skipping index entry '➕'. Tokenization of '+' yields empty set.
21:33:36 [warn:albert] Skipping index entry '➖'. Tokenization of '-' yields empty set.
21:33:36 [warn:albert] Skipping index entry '‼️'. Tokenization of '!!' yields empty set.
21:33:36 [warn:albert] Skipping index entry '⁉️'. Tokenization of '!?' yields empty set.
21:33:36 [warn:albert] Skipping index entry '⁉️'. Tokenization of '?' yields empty set.
21:33:36 [warn:albert] Skipping index entry '❓'. Tokenization of '?' yields empty set.
21:33:36 [warn:albert] Skipping index entry '❔'. Tokenization of '?' yields empty set.
21:33:36 [warn:albert] Skipping index entry '❕'. Tokenization of '!' yields empty set.
21:33:36 [warn:albert] Skipping index entry '❗'. Tokenization of '!' yields empty set.
21:33:36 [warn:albert] Skipping index entry '✳️'. Tokenization of '*' yields empty set.
21:33:36 [warn:albert] Skipping index entry '✴️'. Tokenization of '*' yields empty set.
21:33:36 [warn:albert] Skipping index entry '❇️'. Tokenization of '*' yields empty set.

Current Behavior

Emojis are always searched when a query is entered

image

Expected Behavior

Emoji search is only triggered if the query starts with : as is configured (Global trigger), like so:
image

Expected results:

image

image

Anything else?

If the un-triggered behavior is intentional, I would still welcome a configuration option.
I can make a PR if the change is welcome.

@ManuelSchneid3r
Copy link
Member

Bildschirmfoto 2024-10-24 um 22 12 09

@AshesITR
Copy link
Author

Whoops, thanks for the quick support! 🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants