[websearch] triggers without space #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, it is useful to search without having to add a space after the trigger.
tdsimao
changed the title
ManuelSchneid3r
force-pushed
the
master
branch
from
5d1c04d
to
cfb9435
Compare
|
The problem here is that all strings containg any of the triggers as prefix will match. I have a lot of websearches, all with a very short (one char) triggers. this would match way to many of regular queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it is useful to search without adding a space after the trigger.
For example, if we often find the string in the form
x:abc, a trigger in the formx:and a queryx:abccould launch a search forabc.This PR allows us to copy the string directly to Albert to trigger such a search, without having to edit the string.