Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsampling documentation #91

Open
Bernadette-Mohr opened this issue Dec 3, 2019 · 4 comments
Open

Subsampling documentation #91

Bernadette-Mohr opened this issue Dec 3, 2019 · 4 comments
Labels

Comments

@Bernadette-Mohr
Copy link

Would it be possible to add examples (ideally for multidimensional df) to the documentation of alchemlyb.preprocessing.subsampling?
At least I am not able to guess the usage of statistical_inefficiency() correctly.

@dotsdl
Copy link
Member

dotsdl commented Dec 3, 2019

Hi @Bernadette-Mohr, welcome to alchemlyb!

I agree that this is sorely needed. It's been on my radar for some time, but your immediate need pushes the priority up for this. I have added producing a PR addressing #63 to my list for this weekend; this should serve as a good concrete example addressing for this issue.

Are you interested in providing feedback once the PR is up?

@Bernadette-Mohr
Copy link
Author

Of course, I'll be glad to help!
And yes, generally adding examples for multidimensional dataframes would be awesome.

@Bernadette-Mohr
Copy link
Author

Hi @dotsdl ,

Thank you for adding the multi-lambda example to the parser documentation! It confirms what I thought the contents were.
But it still doesn't help me with my original question: How would I extract uncorrelated samples from this dataframe with the subsampling module?
No matter what I tried, it either throws an error or returns me the same 2-3 rows for every lambda step, so probabely just acting like slicing.

@Bernadette-Mohr
Copy link
Author

Sorry to complain again, but a hint at how to extract the individual contributions of VdW and Coulomb interactions would be helpful too.
I guess I would have to split the multiindex dataframe by coul-lambda=1.0 AND vdw-lambda != 0.0, but that's just a guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants