Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBER - more test file are needed #69

Closed
DrDomenicoMarson opened this issue Sep 24, 2022 · 1 comment · Fixed by #71
Closed

AMBER - more test file are needed #69

DrDomenicoMarson opened this issue Sep 24, 2022 · 1 comment · Fixed by #71

Comments

@DrDomenicoMarson
Copy link
Contributor

DrDomenicoMarson commented Sep 24, 2022

To increase overall coverage, I should add some more files (at least two for now), as they are needed to test some part o the code that is not reached right now.

To do so I propose to create also a function to load single files, in this way it's much easier to prepare the single tests needed for everything we are missing right now. The same function could then be used to switch to more precise testing of invalid files, as reported in #65.

I already have a PR ready for this, which tests three missing branches in the AMBER parser (I already prepared also the PR with the test for alchemlyb, but this will have to wait until the merge of PR #240.

After these 3 tests are added only one line of AMBER parser will be left out.

@xiki-tempula
Copy link
Collaborator

Sorry, I was not reading this issue when I was closing #65. I finally understand what you are suggesting now. Initially, I thought that you just need a random file from a set but now I understand that each file in load_invalidfiles represents a special case and the naming of the invalid files is not the clearest thing in the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants