Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pool/builder] failed EREP-015 Paymaster opsSeen decrement test #904

Open
shunsukew opened this issue Nov 5, 2024 · 0 comments
Open

[pool/builder] failed EREP-015 Paymaster opsSeen decrement test #904

shunsukew opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working needs-triage Issue needs triage

Comments

@shunsukew
Copy link
Contributor

Describe the bug

Rundler fails test test_paymaster_on_account_failure in spec tests.

EREP-015 A `paymaster` should not have its opsSeen incremented on failure of factory or account

To reproduce

Run spec test.

Expected behavior

Paymaster opsSeen should decrement after the second validation checks if User Operations fail due to factory or account error.

Logs

+ pdm run pytest -rA -W ignore::DeprecationWarning --url http://localhost:3000/ --entry-point 0x0000000071727De22E5E9d8BAf0edAc6f37da032 --ethereum-node http://localhost:8545/ -k test_paymaster_on_account_failure -vv
======================================================================== test session starts =========================================================================
platform darwin -- Python 3.10.15, pytest-8.3.1, pluggy-1.5.0 -- /Users/shunsuke/alchemy/rundler/test/spec-tests/v0_7/bundler-spec-tests/.venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/shunsuke/alchemy/rundler/test/spec-tests/v0_7/bundler-spec-tests
configfile: pyproject.toml
plugins: web3-6.11.0
collected 185 items / 184 deselected / 1 skipped / 1 selected                                                                                                        

tests/single/reputation/test_erep.py::test_paymaster_on_account_failure FAILED                                                                                 [100%]

...

>       assert post == pre
E       AssertionError: assert Reputation(address='0x0a95d6f554faef4e2f804161037aa93e6e245ead', opsSeen=6, opsIncluded=2, status='ok') == Reputation(address='0x0a95d6f554faef4e2f804161037aa93e6e245ead', opsSeen=5, opsIncluded=2, status='ok')
E         
E         Matching attributes:
E         ['address', 'opsIncluded', 'status']
E         Differing attributes:
E         ['opsSeen']
E         
E         Drill down into differing attribute opsSeen:
E           opsSeen: 6 != 5
@shunsukew shunsukew added bug Something isn't working needs-triage Issue needs triage labels Nov 5, 2024
@shunsukew shunsukew changed the title Failed EREP-015 Paymaster opsSeen decrement test [pool/builder] failed EREP-015 Paymaster opsSeen decrement test Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

1 participant