Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): introduce entry point routing #636

Merged
merged 12 commits into from
Mar 31, 2024
Merged

feat(rpc): introduce entry point routing #636

merged 12 commits into from
Mar 31, 2024

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Mar 11, 2024 •
edited
Loading

Adds:

  • Lots of new RPC types for 0.7
  • A new abstraction for interacting with user operation events, which is used for getByHash and getReceipt.
  • A new concept, entry point router, that the API uses to route requests to the correct EP (or scan all EPs), and hides type complexity

@dancoombs dancoombs force-pushed the danc/uo-enum-2 branch 7 times, most recently from 9df119c to 2ee72e0 Compare March 14, 2024 12:36
@dancoombs dancoombs changed the title feat: WIP rpc entry point routing feat(rpc): introduce entry point routing Mar 14, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.28881% with 2100 lines in your changes are missing coverage. Please review.

Project coverage is 55.82%. Comparing base (d951f14) to head (8d0f94d).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_sender.rs 0.00% <ø> (ø)
crates/builder/src/server/remote/protos.rs 0.00% <ø> (ø)
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (+7.69%) ⬆️
crates/pool/src/mempool/paymaster.rs 93.62% <100.00%> (+0.01%) ⬆️
crates/pool/src/mempool/pool.rs 95.78% <100.00%> (-0.01%) ⬇️
crates/pool/src/mempool/reputation.rs 85.25% <ø> (+5.13%) ⬆️
crates/pool/src/server/remote/server.rs 0.00% <ø> (ø)
crates/provider/src/traits/entry_point.rs 20.00% <ø> (ø)
crates/rpc/src/admin.rs 0.00% <ø> (ø)
crates/rpc/src/eth/events/mod.rs 100.00% <100.00%> (ø)
... and 61 more
Flag Coverage Δ
unit-tests 55.82% <39.28%> (-2.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.64% <16.32%> (-1.18%) ⬇️
dev 0.00% <0.00%> (ø)
pool 65.33% <65.60%> (+0.72%) ⬆️
provider 9.08% <0.77%> (-4.87%) ⬇️
rpc 29.08% <36.21%> (-4.69%) ⬇️
sim 84.33% <38.06%> (-3.15%) ⬇️
tasks ∅ <ø> (∅)
types 66.50% <34.85%> (-8.43%) ⬇️
utils 16.73% <ø> (ø)

@dancoombs dancoombs force-pushed the danc/rpc-router branch 2 times, most recently from 1b758f3 to 0e8fe52 Compare March 14, 2024 19:03
@dancoombs dancoombs marked this pull request as ready for review March 14, 2024 19:05
@dancoombs dancoombs force-pushed the danc/rpc-router branch 2 times, most recently from 5d5abdc to 639d1e1 Compare March 14, 2024 19:32
@dancoombs dancoombs linked an issue Mar 14, 2024 that may be closed by this pull request
refactor: RPC types and serde #418
Closed
@dancoombs dancoombs mentioned this pull request Mar 25, 2024
Merged
0xfourzerofour
0xfourzerofour approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and some nice cleanups just a couple small comments

crates/rpc/src/eth/events/v0_6.rs Outdated Show resolved Hide resolved
crates/rpc/src/eth/events/v0_6.rs Outdated Show resolved Hide resolved
crates/rpc/src/eth/events/v0_6.rs Outdated Show resolved Hide resolved
crates/rpc/src/eth/router.rs Show resolved Hide resolved
@dancoombs dancoombs merged commit 07c8cae into danc/uo-enum-2 Mar 31, 2024
8 checks passed
@dancoombs dancoombs deleted the danc/rpc-router branch March 31, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson

@alex-miao alex-miao Awaiting requested review from alex-miao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: RPC types and serde
2 participants
@dancoombs @0xfourzerofour