Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be possible to instanciate accounts from the public key ? #21

Open
hoh opened this issue Apr 18, 2023 · 1 comment
Open

Should it be possible to instanciate accounts from the public key ? #21

hoh opened this issue Apr 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@hoh
Copy link
Member

hoh commented Apr 18, 2023

This would provide a more object-oriented approach to signature verification, and most methods would still work.

Related to https://github.com/aleph-im/aleph-sdk-python/pull/19/files that creates a function verify_signature(...) outside of the class.

@hoh hoh added the enhancement New feature or request label Apr 18, 2023
@MHHukiewitz
Copy link
Member

We agreed to do this refactoring at a later stage, when besides signature verification, encryption is also an advertised (or at least well-tested) feature of the SDK, so that the resulting distinction between PrivateAccount/KeypairAccount and PublicAccount/PubKeyAccount has more utility for the end user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants