Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create A Login Page (Utilize Animated Logo) #46

Open
tarunnsingh opened this issue Oct 5, 2020 · 53 comments
Open

Create A Login Page (Utilize Animated Logo) #46

tarunnsingh opened this issue Oct 5, 2020 · 53 comments
Labels
enhancement New feature or request frontend good first issue Good for newcomers Hacktoberfest

Comments

@tarunnsingh
Copy link
Member

tarunnsingh commented Oct 5, 2020

🆕 We are adding auth-system. We need a Login page and a Register Page.

Make your changes to master branch and only in the client folder.

Also show your creativity and make use of the New Animated Logo for the Website which is in client/src/static/logo

@tarunnsingh tarunnsingh added enhancement New feature or request good first issue Good for newcomers Hacktoberfest frontend labels Oct 5, 2020
@tarunnsingh tarunnsingh pinned this issue Oct 5, 2020
@pawan-git7979
Copy link

is it open , can i do it.

@tarunnsingh
Copy link
Member Author

is it open , can i do it.

Yes it is open, please first make sure you have Read the Docs and you are able to run the app locally.

@pawan-git7979
Copy link

okk.

@pawan-git7979
Copy link

bro, i have clone the repo , but where is the config folder, i not able to find it.

@tarunnsingh
Copy link
Member Author

bro, i have clone the repo , but where is the config folder, i not able to find it.

You must be on the master branch, now you need to go inside the client folder and run npm start. This runs the frontend, and points to the backend api which is already hosted, so you do not need to start the server at your end.

@pawan-git7979
Copy link

i am facing this issue.
Screenshot from 2020-10-05 12-56-30

@tarunnsingh
Copy link
Member Author

cd client
npm install -> installs all dependencies and creates react-scripts.
npm start -> starts you scripts

Did you do this?

@pawan-git7979
Copy link

i also run npm install, then also this is showing the error.

@tarunnsingh
Copy link
Member Author

Okay let me see.

@pawan-git7979
Copy link

Screenshot from 2020-10-05 13-04-07

@tarunnsingh
Copy link
Member Author

tarunnsingh commented Oct 5, 2020

Your NPM version is outdated perhaps. Please check here.. I tried it locally and works fine. If it dosent help revert here with your node and npm version.

node -version and npm -version

@harshalkaigaonkar
Copy link
Contributor

i can do it

@tarunnsingh
Copy link
Member Author

i can do it

Hey @harshalkaigaonkar I have a new issue for you, if you would like to work on it?

@tarunnsingh
Copy link
Member Author

@pawan-git7979 make changes to master branch only, no need to work on auth-setup.

@harshalkaigaonkar
Copy link
Contributor

i can do it

Hey @harshalkaigaonkar I have a new issue for you, if you would like to work on it?

ya Sure!

@tarunnsingh
Copy link
Member Author

i can do it

Hey @harshalkaigaonkar I have a new issue for you, if you would like to work on it?

ya Sure!

See #50

@pawan-git7979
Copy link

again npm start is not working, npm install somehow works, but it showing many warnings.

Screenshot from 2020-10-05 13-52-24

@tarunnsingh
Copy link
Member Author

@pawan-git7979 Okay let me FIX this, I'll update the README and notify you here. You can then start your work.

@pawan-git7979
Copy link

okay thanks brother.
i will work on this , plss don't assign this to anyone, its a request.

@tarunnsingh
Copy link
Member Author

Hey @pawan-git7979 Give it a try now, taking reference from the README.

@tarunnsingh
Copy link
Member Author

Also, fetch the code again.

@pawan-git7979
Copy link

bro, again i m facing the issue. getting the error in process.on line
Screenshot from 2020-10-06 21-57-52

@tarunnsingh
Copy link
Member Author

@imabp Can you give some insights here too?

@imabp
Copy link
Contributor

imabp commented Oct 6, 2020

@pawan-git7979
Lets get with a fresh installation completely.
Before doing that, just check it out, that everything okay and updated for your linux distros, specially node version and npm .
Node version should be latest LTS 12.18.4

skipping the cloning part

If you are working on frontend

$git checkout master
$cd client
$npm i 
$npm start

If you are working on backend

First you need to setup the devkeys and mongodb uri stuff, as mentioned on readme
This runs server at port:3000 , make sure nothing is already running there.

$git checkout v1-deployment
$npm i 
$npm start

@pawan-git7979
Copy link

My node version is v3.3.1

@aditi-singh25
Copy link

Sure, will embed gif there. Also one more thing, to link that login page I have to use react router. Would it be fine, or you have some other ways to link that login page?

@imabp
Copy link
Contributor

imabp commented Oct 7, 2020

Developers Update:

Clone the two branches in two separate folders
using following command

For Backend

 git clone -b v1-deployment --single-branch https://github.com/<username>/alexa-community-jaipur

For Frontend

 git clone -b master --single-branch https://github.com/<username>/alexa-community-jaipur

This will help you to work independently

@tarunnsingh
Copy link
Member Author

Sure, will embed gif there. Also one more thing, to link that login page I have to use react router. Would it be fine, or you have some other ways to link that login page?

react router is fine.

@tarunnsingh
Copy link
Member Author

Assigning this to @aditi-singh25. @pawan-git7979 if you got it working locally, let me know we have more stuff for you.

@pawan-git7979
Copy link

I have try almost everything..but the version of node is not upgrading in Linux...i am using the Linux first time..nd i have installed it just 1 week before.. before that i had been using windows.

@tarunnsingh
Copy link
Member Author

Why don't you comletely uninstall it and install it again

@imabp
Copy link
Contributor

imabp commented Oct 8, 2020

@pawan-git7979 I recommend to get familiar with Linux, if you are using it for first time, because you need to install a bunch of packages to make it ready for development. I say, if your primary development platform is windows, then go for windows if you want to contribute without any breaking changes in the application.

Anyways that's a personal choice, Windows or Linux ?

Here is how you can install latest node version on linux (EASY WAY)

  1. Start by updating the package repository with the command:
    sudo apt update

  2. Download the following dependencies by typing:
    sudo apt install build-essential checkinstall libssl-dev

  3. Install NVM using the curl command:
    curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.35.1/install.sh | bash

  4. Close and reopen the terminal.

  5. Then, verify if you have successfully installed NVM:
    nvm --version

  6. Before upgrading Node.js, check which version you have running on the system:
    nvm ls

  7. Now you can check for newly available releases with:
    nvm ls-remote

list-available-nodejs-versions

  1. To install the latest version, use the nvm command with the specific Node.js version:
    nvm install [version.number]

Source: phoenixnap

@tarunnsingh
Copy link
Member Author

@aditi-singh25 Any Progress?

@aditi-singh25
Copy link

aditi-singh25 commented Oct 13, 2020 via email

@sujitIwale
Copy link

is it open ?can you assign it to me?

@imabp
Copy link
Contributor

imabp commented Oct 24, 2020

@sujitIwale do you want to work on backend (auth Setup) or frontend (auth UI) ,

If backend, please clone the v1-deployment branch only
If frontend, please clone the master branch.

@sujitIwale
Copy link

I want to work on frontend.

@sujitIwale
Copy link

assign it to me.

@sujitIwale
Copy link

I am using react-router-dom for login page

@tarunnsingh tarunnsingh assigned sujitIwale and unassigned sujitIwale Oct 24, 2020
@tarunnsingh
Copy link
Member Author

@sujitIwale Most of the work is already done, if you want to make some more changes /additions see the auth-setup-backend and auth-setup-frontend branches. And let me know what more additions can you make on this.

@imabp
Copy link
Contributor

imabp commented Oct 24, 2020

@tarunnsingh is back !!
Welcome brother :D 👏👏👏

@sujitIwale
Copy link

can I add home button on login and register page which redirects user to home screen?

@tarunnsingh
Copy link
Member Author

Hey @imabp 😄
No no bro! I did this work a few days back, still not getting time for github work.

@tarunnsingh
Copy link
Member Author

can I add home button on login and register page which redirects user to home screen?

@sujitIwale
The Community-Logo is already there on the login pages, just add a link to home on those logos. That would work 👍🏼

@tarunnsingh
Copy link
Member Author

@imabp Needed help on this. The access_token (the cookie) is not getting stored in the browser when logged in, could you please look into it, this is pending from quite a few days now.

@tarunnsingh
Copy link
Member Author

@sujitIwale
Could you design a user-profile page?

@sujitIwale
Copy link

@sujitIwale
Could you design a user-profile page?

could you make it an issue?

@imabp
Copy link
Contributor

imabp commented Oct 24, 2020

@tarunnsingh
Yea sure, after few days, I will be active here.

@tarunnsingh
Copy link
Member Author

@sujitIwale
Could you design a user-profile page?

could you make it an issue?

Comment on #76 to be assigned

@tarunnsingh
Copy link
Member Author

@tarunnsingh
Yea sure, after few days, I will be active here.

Sure Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

6 participants